fix(bump.py): CHANGELOG.md
gets git added and commited correctly
#581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The elements in
version_files
may contain not only a file path, but also a regex after a colon. Thus make sure to only pass the file path togit add
.Fixes a regression introduced in 12b56ad.
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
CHANGELOG.md
getsgit added
and commited no matter what version files (+ regex) one specifies.Before and After
Before the following, broken, command was executed:
git add CHANGELOG.md pyproject.toml:^version src/my_package/__init__.py:^__version__
With this MR, the command looks like this:
git add CHANGELOG.md pyproject.toml src/my_package/__init__.py
Steps to Test This Pull Request
Have the following commitizen settings in
pyproject.toml
file:In the git repo of
my_package
make sure there is noCHANGELOG.md
file tracked by git yet.Running
cz bump
will update the version correctly and also write the changelog file, but fail togit add
it.Additional context